From 894a04d10d2c18eaf3f930ee33c97f1b2413c587 Mon Sep 17 00:00:00 2001 From: Rohit Rao Date: Fri, 22 Sep 2017 18:51:30 +0000 Subject: [PATCH] [ios] Disables testInputAccessoryViewNavigationButtons on iOS 11. This test was already disabled on iOS 11 iPad, but it has started failing on iPhone as well in the iOS 11 GM build. BUG=753098 Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83 Reviewed-on: https://chromium-review.googlesource.com/664837 Commit-Queue: Rohit Rao (ping after 24h) Commit-Queue: Justin Cohen Reviewed-by: Olivier Robin Reviewed-by: Justin Cohen Cr-Original-Commit-Position: refs/heads/master@{#501604}(cherry picked from commit 9ca5963f858ce1fa69eb2e282724fa75ff5a1cda) Reviewed-on: https://chromium-review.googlesource.com/679294 Reviewed-by: Moe Ahmadi Cr-Commit-Position: refs/branch-heads/3202@{#402} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} --- ios/showcase/payments/sc_payments_editor_egtest.mm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ios/showcase/payments/sc_payments_editor_egtest.mm b/ios/showcase/payments/sc_payments_editor_egtest.mm index 9d9ae431882d8..468024215050c 100644 --- a/ios/showcase/payments/sc_payments_editor_egtest.mm +++ b/ios/showcase/payments/sc_payments_editor_egtest.mm @@ -209,8 +209,9 @@ - (void)testInputAccessoryViewCloseButton { // navigate between the textfields. - (void)testInputAccessoryViewNavigationButtons { // TODO(crbug.com/753098): Re-enable this test on iOS 11 iPad once - // grey_typeText works on iOS 11. - if (base::ios::IsRunningOnIOS11OrLater() && IsIPadIdiom()) { + // grey_typeText works on iOS 11. The test failes on iOS 11 iPhone as well, + // but possibly for a different reason. + if (base::ios::IsRunningOnIOS11OrLater()) { EARL_GREY_TEST_DISABLED(@"Test disabled on iOS 11."); }