Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with projects using protobuf 2.28 #414

Open
kornelski opened this issue Sep 11, 2023 · 1 comment · May be fixed by #415
Open

Incompatible with projects using protobuf 2.28 #414

kornelski opened this issue Sep 11, 2023 · 1 comment · May be fixed by #415

Comments

@kornelski
Copy link

In Cargo dependency versions are deduplicated across the entire workspace (per each major version). The hardcoded dependency protobuf in tensorflow forces all users of tensorflow to use exactly this version of protobuf 2.27.1. It causes a fatal error when resolving dependencies if any dependency anywhere wants protobuf 2.28.

Unfortunately, this version requirement is very public and global. In Cargo the exact = version requirements are quite disruptive. Please don't hardcode the version. If you can't use 2.28, consider forking the crate and depending on the fork, which will not conflict with other uses of the protobuf crate.

rust/Cargo.toml

Lines 31 to 32 in 62a3019

# This is used internally but not intended to be exposed through the API.
protobuf = "=2.27.1"

@dskkato dskkato linked a pull request Sep 12, 2023 that will close this issue
@dskkato
Copy link
Contributor

dskkato commented Sep 12, 2023

I think the protobuf version limitation is unintended, so you can remove the =. Below is a note of relevant information.

rust-protobuf releases

  • 2.27.1 -> Feb 5th, 2022
  • 2.28.0 -> Sep 26th, 2022
  • 3.2.0 (latest?) -> Sep 26th, 2022

According to the current Readme, rust-protobuf development is scheduled to move to version 3, and version 2 will soon no longer be maintained. Maybe we should migrate too at some point.

https://github.com/stepancheg/rust-protobuf/blob/master/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants