Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Detect chain ID mismatches between KMS and validators #146

Open
tarcieri opened this issue Jan 3, 2019 · 1 comment
Open

Detect chain ID mismatches between KMS and validators #146

tarcieri opened this issue Jan 3, 2019 · 1 comment

Comments

@tarcieri
Copy link
Contributor

tarcieri commented Jan 3, 2019

When the chain_id is configured incorrectly in tmkms.toml, this manifests in practice as the following error (on gaiad / tendermint side):

Error attempting to add vote
module=consensus err="Failed to verify vote with ChainID game_of_stakes_3 and PubKey PubKeyEd25519{4A25C6640A1F72B9C975338294EF51B6D1C33158BB6ECBA69FBC3FB5A33C9DCE}: Invalid signature"

Ideally either side (or both) would notice the other is advertising an unexpected chain_id and print a (potentially fatal) error message

@liamsi
Copy link
Contributor

liamsi commented Jan 3, 2019

The problem here is that the chain_id currently is not send around between the kms <-> tendemint. So both sides currently do not know of the other's chain_id (hence can't check if they differ). There is an open issue about sending along the chain_id with the vote: tendermint/tendermint#2665 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants