From 47360e7631041d0ae7645f2a7135c937c8dcf16b Mon Sep 17 00:00:00 2001 From: Alex Tideman Date: Tue, 29 Aug 2023 09:03:47 -0500 Subject: [PATCH 1/9] WIP: testing things out --- .../schedule/schedule-frequency.svelte | 20 ++++++++++++------- .../schedule/schedules-table-row.svelte | 9 ++++----- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/src/lib/components/schedule/schedule-frequency.svelte b/src/lib/components/schedule/schedule-frequency.svelte index 7c0b07db6..0969cdd9c 100644 --- a/src/lib/components/schedule/schedule-frequency.svelte +++ b/src/lib/components/schedule/schedule-frequency.svelte @@ -1,8 +1,9 @@
- {#if calendar} -

- {commentOrCalendarToFrequency(calendar)} -

- {:else} + + +
diff --git a/src/lib/components/schedule/schedules-table-row.svelte b/src/lib/components/schedule/schedules-table-row.svelte index 1a88a5829..b0c1fff10 100644 --- a/src/lib/components/schedule/schedules-table-row.svelte +++ b/src/lib/components/schedule/schedules-table-row.svelte @@ -1,6 +1,6 @@ +
+ {#if calendar} +

+ {commentOrCalendarToFrequency(calendar)} +

+ {:else} +

+ {intervalToComment(intervalSecs)} +

+

+ {intervalToComment(phaseSecs, true)} +

+ {/if} +
+
{/if} -
- -
+
+
Date: Tue, 29 Aug 2023 14:24:40 -0500 Subject: [PATCH 3/9] Use CodeBlock for frequency in all cases, change layout of schedule view --- .../schedule-advanced-settings.svelte | 55 ++++++++++--------- .../schedule/schedule-frequency.svelte | 33 +---------- ...dule-memo.svelte => schedule-notes.svelte} | 6 +- .../schedule/schedule-recent-runs.svelte | 6 +- .../schedule/schedules-table-row.svelte | 14 ++++- .../schedule/schedules-table.svelte | 2 +- src/lib/holocene/code-block.svelte | 4 +- src/lib/i18n/locales/en/common.ts | 1 + src/lib/pages/schedule-view.svelte | 30 ++++------ 9 files changed, 66 insertions(+), 85 deletions(-) rename src/lib/components/schedule/{schedule-memo.svelte => schedule-notes.svelte} (56%) diff --git a/src/lib/components/schedule/schedule-advanced-settings.svelte b/src/lib/components/schedule/schedule-advanced-settings.svelte index 532460b0f..8a69ff081 100644 --- a/src/lib/components/schedule/schedule-advanced-settings.svelte +++ b/src/lib/components/schedule/schedule-advanced-settings.svelte @@ -1,44 +1,49 @@ - -{#if show} -

- {translate('schedules', 'start-time')} - {spec?.startTime ?? translate('none')} -

-

- {translate('schedules', 'end-time')}{spec?.endTime ?? translate('none')} -

-

{translate('schedules', 'jitter')}{spec?.jitter ?? translate('none')}

-

- {translate('schedules', 'exclusion-calendar')}{spec?.excludeCalendar?.[0] ?? - translate('none')} -

- {#if state?.limitedActions} + +
+ + {#if show} +

+ {translate('schedules', 'start-time')} + {spec?.startTime ?? translate('none')} +

+

+ {translate('schedules', 'end-time')}{spec?.endTime ?? translate('none')} +

+

{translate('schedules', 'jitter')}{spec?.jitter ?? translate('none')}

+

+ {translate('schedules', 'exclusion-calendar')}{spec + ?.excludeCalendar?.[0] ?? translate('none')} +

+ {#if state?.limitedActions} +

+ {translate('schedules', 'remaining-actions')}{state?.remainingActions ?? + translate('none')} +

+ {/if}

- {translate('schedules', 'remaining-actions')}{state?.remainingActions ?? + {translate('schedules', 'overlap-policy')}{policies?.overlapPolicy ?? translate('none')}

{/if} -

- {translate('schedules', 'overlap-policy')}{policies?.overlapPolicy ?? - translate('none')} -

-{/if} +