Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "make" fails when env TEMPORAL_CLOUD_API_KEY is set #349

Closed
maxramqvist opened this issue Jun 11, 2024 · 1 comment
Closed

[Bug] "make" fails when env TEMPORAL_CLOUD_API_KEY is set #349

maxramqvist opened this issue Jun 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@maxramqvist
Copy link

maxramqvist commented Jun 11, 2024

What are you really trying to do?

Install tcld according to the instructions in the docs: https://docs.temporal.io/cloud/tcld#install-tcld

Describe the bug

If I run your instructions with the env var TEMPORAL_CLOUD_API_KEY set as an actual api key, the tests will fail:

git clone https://github.com/temporalio/tcld.git
cd tcld
make

Make will fail with:

FAIL	github.com/temporalio/tcld/app	10.486s
FAIL
make: *** [Makefile:27: test] Error 1

Minimal Reproduction

  1. Clone this repo
  2. export TEMPORAL_CLOUD_API_KEY=an-actual-api-key
  3. make

Environment/Versions

This repo with commit 0549218 <- latest on main as of right now.
Go v1.22.3 on Ubuntu 22.04

@briankassouf
Copy link

Fixed by #399:

% TEMPORAL_CLOUD_API_KEY=an-actual-api-key make
ok      github.com/temporalio/tcld/app  8.303s  coverage: 79.7% of statements
ok      github.com/temporalio/tcld/cmd/tcld     1.629s  coverage: 75.0% of statements
ok      github.com/temporalio/tcld/utils        1.243s  coverage: 64.7% of statements
passed

Please let us know if you continue to have issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants