Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update requests should set first_execution_run_id #682

Open
dandavison opened this issue Nov 1, 2024 · 0 comments
Open

[Bug] Update requests should set first_execution_run_id #682

dandavison opened this issue Nov 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dandavison
Copy link
Contributor

dandavison commented Nov 1, 2024

Update requests do not send first_execution_run_id:

async def start_workflow_update(
self, input: StartWorkflowUpdateInput
) -> WorkflowUpdateHandle[Any]:
# Build request
req = temporalio.api.workflowservice.v1.UpdateWorkflowExecutionRequest(
namespace=self._client.namespace,
workflow_execution=temporalio.api.common.v1.WorkflowExecution(
workflow_id=input.id,
run_id=input.run_id or "",
),
request=temporalio.api.update.v1.Request(
meta=temporalio.api.update.v1.Meta(
update_id=input.update_id or str(uuid.uuid4()),
identity=self._client.identity,
),
input=temporalio.api.update.v1.Input(
name=input.update,
),
),
wait_policy=temporalio.api.update.v1.WaitPolicy(
lifecycle_stage=temporalio.api.enums.v1.UpdateWorkflowExecutionLifecycleStage.ValueType(
input.wait_for_stage
)
),
)
if input.args:
req.request.input.args.payloads.extend(
await self._client.data_converter.encode(input.args)
)
if input.headers is not None:
temporalio.common._apply_headers(
input.headers, req.request.input.header.fields
)

However, they should, and other SDKs do.

Also, is it correct that we don't use the run ID from the response when constructing the returned update handle?

@dandavison dandavison added the bug Something isn't working label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant