Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistency on MaximumAttempts attribute between local activities and "normal" activities #1727

Open
antmendoza opened this issue Mar 31, 2023 · 0 comments · May be fixed by #2257
Open

inconsistency on MaximumAttempts attribute between local activities and "normal" activities #1727

antmendoza opened this issue Mar 31, 2023 · 0 comments · May be fixed by #2257
Labels
good first issue
Milestone
1.20.0

Comments

@antmendoza
Copy link
Member

Expected Behavior

setting setMaximumAttempts=0 (or not setting any value, default = 0) for local activities should make the activity retry forever.

I expect the same behavior as "normal" activities, where MaximumAttempts=0 implies retry forever.

Actual Behavior

when MaximumAttempts is set to 0, local activities do not retry

Steps to Reproduce the Problem

HelloLocalActivity.java.zip

Specifications

  • Version:
  • Platform:
@Spikhalskiy Spikhalskiy added this to the 1.20.0 milestone Apr 20, 2023
@Spikhalskiy Spikhalskiy self-assigned this Apr 20, 2023
@pragnareddye pragnareddye mentioned this issue Jun 28, 2023
Open
@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this issue Oct 5, 2024
Closed
ghaskins added a commit to ghaskins/temporal-sdk-java that referenced this issue Oct 7, 2024
@ghaskins
[temporalio#1727] Use default RetryOptions for LocalActivities when n…
8201f72 
…ot set or setMaximumAttempts(0)

Setting setMaximumAttempts=0 (or not setting any value, default = 0) for local activities should make the activity retry forever.

This is currently broken because the logic treats both no policy set and a policy with all default values (including MaxiumAttempts = 0)
as abort conditional.  What should happen (at least according the doc and to align with normal activities) is that no policy set should
be processed according to the default values of the retry policy, which includes unlimited retries when the MaxiumAttempts = 0.

Fixes temporalio#1727

Signed-off-by: Greg Haskins <[email protected]>
This was referenced Oct 7, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

[#1727] Use default RetryOptions for LocalActivities when not set ghaskins/temporal-sdk-java
3 participants
@lorensr @antmendoza @Spikhalskiy