-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA to check api-go compatibility #1749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Note, when making the api
side, you may want the ability to bypass. The reason one might want to bypass is because we know the API is incompatible and we plan on tagging a new Go SDK release with the new API release immediately after API release is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but a general question about moving this to api-go
as there seems to be no benefit to it being in the SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, can we just put this whole workflow inside of api-go
? Is there any reason it needs to be inside the SDK repo?
@cretz Sure, I had initially put in the |
Yes, this check is very Go specific. I know the API repo has some Go things, but in theory the API repo is supposed to be language agnostic. Having said that, if it is easier to fail the release from |
Makes sense, moved to |
What was changed
GHA to check compatibility of api-go
Why?
Automation
Checklist
Closes
How was this tested: