Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA to check api-go compatibility #1749

Closed
wants to merge 3 commits into from

Conversation

rodrigozhou
Copy link
Contributor

What was changed

GHA to check compatibility of api-go

Why?

Automation

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@rodrigozhou rodrigozhou requested review from bergundy and cretz December 9, 2024 21:00
@rodrigozhou rodrigozhou requested a review from a team as a code owner December 9, 2024 21:00
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note, when making the api side, you may want the ability to bypass. The reason one might want to bypass is because we know the API is incompatible and we plan on tagging a new Go SDK release with the new API release immediately after API release is complete.

.github/workflows/check-api-go.yml Show resolved Hide resolved
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a general question about moving this to api-go as there seems to be no benefit to it being in the SDK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, can we just put this whole workflow inside of api-go? Is there any reason it needs to be inside the SDK repo?

@rodrigozhou
Copy link
Contributor Author

@cretz Sure, I had initially put in the api repo because it's where the release process starts. Any particular reason to put in api-go instead of api?

@cretz
Copy link
Member

cretz commented Dec 10, 2024

Any particular reason to put in api-go instead of api?

Yes, this check is very Go specific. I know the API repo has some Go things, but in theory the API repo is supposed to be language agnostic. Having said that, if it is easier to fail the release from api instead of api-go, no problem.

@rodrigozhou
Copy link
Contributor Author

Makes sense, moved to api-go repo: temporalio/api-go#200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants