Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update to tonic 0.10 #626

Closed
cretz opened this issue Nov 6, 2023 · 5 comments · Fixed by #782
Closed

[Feature Request] Update to tonic 0.10 #626

cretz opened this issue Nov 6, 2023 · 5 comments · Fixed by #782
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Nov 6, 2023

Describe the solution you'd like

Update tonic in workspace to 0.10 and fix anything needed. In Python I saw something around the proxier! macro and IntoRequest, but I didn't investigate and it may be unique to Python's macro.

@cretz cretz added the enhancement New feature or request label Nov 6, 2023
@Sushisource
Copy link
Member

As usual this needs https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-otlp to update to newer tonic first which may take a while

@cretz
Copy link
Member Author

cretz commented Nov 6, 2023

I see. open-telemetry/opentelemetry-rust#1310 is in PR but unsure when it'll move through. I'll come back to this when I see that (or similar) move.

@h7kanna
Copy link
Contributor

h7kanna commented Nov 10, 2023

Ideally, this crate's tonic dependency can (possibly) be updated independently of that of Opentelemetry's ?
I mean like this

core/Cargo.toml

opentelemetry-tonic = { version = "0.9", package = "tonic", features = ["tls", "tls-roots"] }

core/src/telemetry/metrics.rs

use opentelemetry_tonic::metadata::MetadataMap;
//use tonic::metadata::MetadataMap;

And update tonic = "0.10" and prost-* to "0.12"
like this master...h7kanna:sdk-core:update-tonic

This can even be applied to #628 (Upgrade OTel to 0.21)

@Sushisource
Copy link
Member

@h7kanna It can be, for sure, but I kinda wanted to avoid having multiple copies of tonic which is a rather large dep. Maybe that's not such a big deal but, so far the need to update as fast as possible hasn't been too important.

@h7kanna
Copy link
Contributor

h7kanna commented Nov 13, 2023

Yes ofcourse, I just wanted to point out that it is possible if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants