-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Update to tonic 0.10 #626
Comments
As usual this needs https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-otlp to update to newer tonic first which may take a while |
I see. open-telemetry/opentelemetry-rust#1310 is in PR but unsure when it'll move through. I'll come back to this when I see that (or similar) move. |
Ideally, this crate's tonic dependency can (possibly) be updated independently of that of Opentelemetry's ? core/Cargo.toml
core/src/telemetry/metrics.rs use opentelemetry_tonic::metadata::MetadataMap;
//use tonic::metadata::MetadataMap; And update tonic = "0.10" and prost-* to "0.12" This can even be applied to #628 (Upgrade OTel to 0.21) |
@h7kanna It can be, for sure, but I kinda wanted to avoid having multiple copies of tonic which is a rather large dep. Maybe that's not such a big deal but, so far the need to update as fast as possible hasn't been too important. |
Yes ofcourse, I just wanted to point out that it is possible if needed. |
Describe the solution you'd like
Update tonic in workspace to
0.10
and fix anything needed. In Python I saw something around theproxier!
macro andIntoRequest
, but I didn't investigate and it may be unique to Python's macro.The text was updated successfully, but these errors were encountered: