From b3ed1e5e3426b3710b75203f016b3122ad467c98 Mon Sep 17 00:00:00 2001 From: Spencer Judge Date: Tue, 21 Nov 2023 10:58:06 -0800 Subject: [PATCH] Review comment --- .../sdk/core/workflow_activation/workflow_activation.proto | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto b/sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto index 7991ac480..2c612b8b8 100644 --- a/sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto +++ b/sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto @@ -27,7 +27,8 @@ import "temporal/sdk/core/common/common.proto"; // // This is because: // * Patches are expected to apply to the entire activation -// * Signal and query handlers should be invoked before workflow routines are iterated +// * Signal and update handlers should be invoked before workflow routines are iterated. That is to +// say before the users' main workflow function and anything spawned by it is allowed to continue. // * Queries always go last (and, in fact, always come in their own activation) // // The downside of this reordering is that a signal or update handler may not observe that some