From 69d5244a3afdf5167189693c073fbcbc4f594d7d Mon Sep 17 00:00:00 2001 From: Dan Davison Date: Sun, 3 Dec 2023 09:28:27 -0500 Subject: [PATCH] oss-1840 investigation: Do not send update event_ids --- core/src/worker/workflow/machines/update_state_machine.rs | 3 +-- sdk-core-protos/src/history_builder.rs | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/core/src/worker/workflow/machines/update_state_machine.rs b/core/src/worker/workflow/machines/update_state_machine.rs index 7a45aaf7e..b143a4a3b 100644 --- a/core/src/worker/workflow/machines/update_state_machine.rs +++ b/core/src/worker/workflow/machines/update_state_machine.rs @@ -73,6 +73,7 @@ pub(super) enum UpdateMachineCommand { pub(super) struct SharedState { message_id: String, instance_id: String, + #[allow(dead_code)] event_seq_id: i64, request: UpdateRequest, } @@ -236,7 +237,6 @@ impl WFMachinesAdapter for UpdateMachine { format!("{}/accept", self.shared_state.message_id), UpdateMsg::Accept(Acceptance { accepted_request_message_id: self.shared_state.message_id.clone(), - accepted_request_sequencing_event_id: self.shared_state.event_seq_id, ..Default::default() }), )?, @@ -245,7 +245,6 @@ impl WFMachinesAdapter for UpdateMachine { format!("{}/reject", self.shared_state.message_id), UpdateMsg::Reject(Rejection { rejected_request_message_id: self.shared_state.message_id.clone(), - rejected_request_sequencing_event_id: self.shared_state.event_seq_id, failure: Some(fail), ..Default::default() }), diff --git a/sdk-core-protos/src/history_builder.rs b/sdk-core-protos/src/history_builder.rs index 9d4edc195..d2317e663 100644 --- a/sdk-core-protos/src/history_builder.rs +++ b/sdk-core-protos/src/history_builder.rs @@ -475,10 +475,10 @@ impl TestHistoryBuilder { self.build_and_push_event(EventType::WorkflowExecutionUpdateAccepted, attrs.into()) } - pub fn add_update_completed(&mut self, accepted_event_id: i64) { + pub fn add_update_completed(&mut self, _accepted_event_id: i64) { let attrs = WorkflowExecutionUpdateCompletedEventAttributes { meta: None, - accepted_event_id, + accepted_event_id: 0, outcome: Some(update::v1::Outcome { value: Some(outcome::Value::Success(Payloads::default())), }),