From d8aec6a29821b2d66a6dc0baabe8d04b27312dd5 Mon Sep 17 00:00:00 2001 From: "Joshua J. Berry" Date: Wed, 27 Nov 2024 11:15:51 -0500 Subject: [PATCH 1/2] Update Node version - For food-delivery: Bump the required Node version to Node 22 (the current LTS), since Node 14 is deprecated. - Update CI to use Node 22 and drop Node 16 (no longer supported). --- .github/workflows/ci.yml | 4 ++-- food-delivery/package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0e10bd20..dfa0d3b4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: fail-fast: false matrix: os: [ ubuntu-latest, windows-latest, macos-latest ] - node: [ 16, 18, 20 ] + node: [ 18, 20, 22 ] project: [ activities-examples, @@ -93,7 +93,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 # Comment out cache line when testing with act: # (Test command is: act --platform ubuntu-latest=lucasalt/act_base:latest) cache: 'npm' diff --git a/food-delivery/package.json b/food-delivery/package.json index 30694699..fe76b986 100644 --- a/food-delivery/package.json +++ b/food-delivery/package.json @@ -22,7 +22,7 @@ "vercel": "^29.0.3" }, "engines": { - "node": ">=14.0.0" + "node": ">=22.0.0" }, "packageManager": "yarn@1.22.19" } From f1aaf7baf13ec142299f0a87935e7957f8df2ccb Mon Sep 17 00:00:00 2001 From: "Joshua J. Berry" Date: Wed, 27 Nov 2024 11:41:53 -0500 Subject: [PATCH 2/2] fix compile error in custom-logger --- custom-logger/src/logging.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/custom-logger/src/logging.ts b/custom-logger/src/logging.ts index 9d73c48a..93de893c 100644 --- a/custom-logger/src/logging.ts +++ b/custom-logger/src/logging.ts @@ -20,8 +20,13 @@ const devLogFormat = winston.format.printf(({ level, message, label, timestamp, // The type signature in winston is wrong const { [LEVEL]: _lvl, [SPLAT]: _splt, [MESSAGE]: _msg, ...restNoSymbols } = rest as Record; return Object.keys(restNoSymbols).length === 0 - ? `${getDateStr(timestamp)} [${label}] ${level}: ${message}` - : `${getDateStr(timestamp)} [${label}] ${level}: ${message} ${util.inspect(restNoSymbols, false, 4, true)}`; + ? `${getDateStr(timestamp as number)} [${label}] ${level}: ${message}` + : `${getDateStr(timestamp as number)} [${label}] ${level}: ${message} ${util.inspect( + restNoSymbols, + false, + 4, + true + )}`; }); /** Create a winston logger from given options */