Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NestJS example uses incorrect worker shutdown #377

Open
TS-Tobias opened this issue Jul 27, 2024 · 0 comments
Open

[Bug] NestJS example uses incorrect worker shutdown #377

TS-Tobias opened this issue Jul 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@TS-Tobias
Copy link

What are you really trying to do?

I am trying to get the Nest.js example to correctly shut down the worker on application termination (for both SIGINT and SIGTERM).

Describe the bug

In the example, the exchange-rates-worker.service.ts calls await this.worker.close();, which doesn't / no longer exists on Worker from @temporalio/worker.

Minimal Reproduction

See nestjs-exchange-rates/apps/worker/src/exchange-rates-worker/exchange-rates-worker.service.ts.

@TS-Tobias TS-Tobias added the bug Something isn't working label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant