-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restruct sentry proj #79
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Moving workflows to a separate file is definitely a good thing these days. Just need to get that activity back in there and I think we'll be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you run poe lint
before pushing (poe format
will fix the formatting issues)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should update the starter.py
to reference the workflow from this file and not through the worker.py
file
Co-authored-by: Chad Retz <[email protected]>
Co-authored-by: Chad Retz <[email protected]>
The code in /sentry currently does not run.
Separating the workflow code into its own file resolves the issue
What was changed
Moved greetings workflow to workflows.py and import workflow within worker
Why?
So others can reference this sample and have no issue running it without alterations being made
Checklist
Closes
How was this tested:
Followed run instructions in README.md. Outputs:
No