Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full query failure structure #566

Open
9 tasks
cretz opened this issue Dec 6, 2024 · 0 comments
Open
9 tasks

Support full query failure structure #566

cretz opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Dec 6, 2024

Describe the solution you'd like

  • SDK workers need to set (converted) query failures on to the new failure field on Add Failure to query result api#503, but making sure to keep setting error_message to the same value as failure.message.
  • SDK clients need to check for this QueryFailedFailure gRPC failure details on query response gRPC failure and if present and failure is present, need to set that as the cause of whatever is returned/thrown/raised today. For backwards compatibility, do not change the error that is used today though, only update the cause.

Per-SDK Tickets

Work cannot commence until temporalio/temporal#6947 is released in a testable dev server. Core-based SDKs don't technically need to wait on Core since it already accepts a full failure type, but in order to test that this works end to end, they need to be able to generate a query failure that is properly serialized, so Core is needed first.

  • Go - TODO after server released
  • Java - TODO after server released
  • Core - TODO after server released
  • TypeScript - TODO after Core
  • Python - TODO after Core
  • .NET - TODO after Core
  • Ruby - TODO after Core
  • PHP - TODO after Go
  • Temporal CLI - TODO after Go
@cretz cretz added the enhancement New feature or request label Dec 6, 2024
@cretz cretz changed the title Support full query failures Support full query failure structure Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant