Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Move/remove third party protos to a separate place instead of root #400

Open
cretz opened this issue Apr 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Apr 23, 2024

Describe the solution you'd like

Other users protoc from the root of this repo. When 108b40a was done, we put google-based proto dependencies at the same path as our own assuming that all users were ok with using these google protos instead of their own (e.g. from https://github.com/protocolbuffers/protobuf/tree/main/src/google/protobuf).

We probably need to either:

  • Put the third party references where the protoc is actually run (e.g. api-go) and only embed them here when testing

or:

  • Move google/api to thirdparty/google-api/google/api
  • Move google/protobuf to thirdparty/google-protobuf/google/protobuf
  • Add -I thirdparty/google-api and -I thirdparty/google-protobuf to our protoc
  • Confirm the fact that thirdparty is nested under our root is ok and can easily be ignored by most protoc use
@cretz cretz added the enhancement New feature or request label Apr 23, 2024
@cretz cretz changed the title [Feature Request] Move third party protocs to a separate place instead of root so they can be excluedd [Feature Request] Move/remove third party protos to a separate place instead of root Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant