You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cretz
changed the title
[Feature Request] Move third party protocs to a separate place instead of root so they can be excluedd
[Feature Request] Move/remove third party protos to a separate place instead of root
Apr 23, 2024
Describe the solution you'd like
Other users
protoc
from the root of this repo. When 108b40a was done, we put google-based proto dependencies at the same path as our own assuming that all users were ok with using these google protos instead of their own (e.g. from https://github.com/protocolbuffers/protobuf/tree/main/src/google/protobuf).We probably need to either:
protoc
is actually run (e.g.api-go
) and only embed them here when testingor:
google/api
tothirdparty/google-api/google/api
google/protobuf
tothirdparty/google-protobuf/google/protobuf
-I thirdparty/google-api
and-I thirdparty/google-protobuf
to ourprotoc
thirdparty
is nested under our root is ok and can easily be ignored by mostprotoc
useThe text was updated successfully, but these errors were encountered: