Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

setExtensionView: not compatible with Autolayout #41

Open
jhurliman opened this issue Dec 1, 2014 · 15 comments
Open

setExtensionView: not compatible with Autolayout #41

jhurliman opened this issue Dec 1, 2014 · 15 comments

Comments

@jhurliman
Copy link

I'd love to use TLYShyNavBar, but it doesn't seem to support extension views when auto layout is enabled. TLYShyViewController.updateYOffset is using self.view.center = ... to move the view which very quickly gets overridden by the auto layout engine. Another project mentioned on your project page, https://github.com/andreamazz/AMScrollingNavbar, seems to have a solution for this using [self followScrollView:self.scrollView usingTopConstraint:self.topLayoutConstraint];. Would it be possible to add a similar solution to this project?

@Mazyod
Copy link
Contributor

Mazyod commented Jan 6, 2015

Thanks for your feedback @jhurliman, and sorry for the late reply.

I'd really love to keep this project as simple as possible, while making sure that the few features it provides actually work properly.

I'd really suggest using custom collection view layouts or similar for any setup that is more complicated than the current one.

I'll keep this issue open for future reference, and for possible solutions that may come up without increasing the complexity.

@swiiifty
Copy link

swiiifty commented Feb 4, 2015

Any fixes yet?

@swiiifty
Copy link

swiiifty commented Feb 6, 2015

I really need a solution. :o)

@kiddomk
Copy link

kiddomk commented Mar 18, 2015

@Mazyod i'm running into similar issue. i have buttons in the tool bar and now i can't click those buttons since it's using autolayout

@markst
Copy link

markst commented Apr 14, 2015

also voting for a similar solution, even just a selector i.e updateYOffset: so that I can update my own constraints.
i.e I have a subview which I do not wish to hide like the extension view, but still wish to lock to the bottom of the navigation bar.

@Mazyod
Copy link
Contributor

Mazyod commented Oct 10, 2015

I'll try to look into this

@Errortype520
Copy link

This is still an issue in latest version. Any update on when Autolayout will be supported?

@Mazyod
Copy link
Contributor

Mazyod commented Dec 8, 2015

@Errortype520 really sorry about that, I haven't looked into this yet. I'll give it higher priority and try to get to it sooner, but can't promise any dates atm.

@Mazyod Mazyod added the URGENT label Dec 8, 2015
@DmitrijMaz
Copy link

Hi, @Mazyod
First of all, thanks for and awesome idea for implementing such kind of things.
I've managed to throw in autolayout in your project and it works well, the only problem i have is properly calculating offset for multiple extension views. If you are interested in my method or willing to help me out, please PM me so we can discuss this.
Thanks.

Here is my implementation.
Hide Nav Bar Delegate.zip

@Mazyod
Copy link
Contributor

Mazyod commented Dec 23, 2015

@DmitrijMaz Hey, sure I am interesting in assisting you in coming with a solution, but it's really difficult to collaborate with zip files. How about forking the repo, making changes, and I'll chip in over there?

@skensell
Copy link

Any updates? I've got the same issue. After profiling I found that constraint-updating was hogging the main thread.

@jajhar
Copy link

jajhar commented Apr 29, 2016

+1 same issue with autolayout

@fruitcoder
Copy link

I also need autolayout support. But even without autolayout, how do you resize extension view's width?? Running your example project and rotating the view controller just leaves the extension view with the portrait width.

@Pitometsu
Copy link

Pitometsu commented Oct 19, 2016

@Mazyod any updates about autolayout support? Is it project active and supported yet? There are so many open issues and old code... The sources does not look simple & well structured btw.

@Pitometsu
Copy link

Pitometsu commented Oct 19, 2016

@markst I have similar problem. Not sure, is it still actual for you, but just in case, you can look at my PR for such functionality #163.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests