Skip to content

Commit

Permalink
fix(html): remove k-height-container from Grid
Browse files Browse the repository at this point in the history 
The container should be rendered only when virtualization is turned on
  • Loading branch information
@TeyaVes
TeyaVes committed Nov 15, 2024
1 parent 3bada96 commit 23ceb00
Show file tree
Hide file tree
Showing 23 changed files with 0 additions and 132 deletions.
1 change: 0 additions & 1 deletion packages/html/src/grid/templates/grid-with-sticky-columns.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ export const GridWithStickyColumns = ({ contentClassName, ...other }: any) => (
</TableTbody>
</GridTable>
</div>
<div className="k-height-container"><div></div></div>
</GridContent>
</GridContainer>
</>
Expand Down
10 changes: 0 additions & 10 deletions packages/html/src/grid/tests/grid-angular.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
{/* set height to scroll height (virtual scrolling) */}
<div style={{ height: '0px' }}></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down Expand Up @@ -144,9 +140,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down Expand Up @@ -208,9 +201,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down
9 changes: 0 additions & 9 deletions packages/html/src/grid/tests/grid-column-menu-blazor.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</div>
</GridContent>
</GridContainer>
Expand Down Expand Up @@ -137,9 +134,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</div>
</GridContent>
</GridContainer>
Expand Down Expand Up @@ -207,9 +201,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</div>
</GridContent>
</GridContainer>
Expand Down
6 changes: 0 additions & 6 deletions packages/html/src/grid/tests/grid-editing-inline-angular.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithEditRow>
Expand Down Expand Up @@ -149,9 +146,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithEditRow>
Expand Down
6 changes: 0 additions & 6 deletions packages/html/src/grid/tests/grid-editing-inline-blazor.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithEditRow>
Expand Down Expand Up @@ -176,9 +173,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithEditRow>
Expand Down
9 changes: 0 additions & 9 deletions packages/html/src/grid/tests/grid-filter-menu-angular.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterMenu>
Expand Down Expand Up @@ -127,9 +124,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterMenu>
Expand Down Expand Up @@ -191,9 +185,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterMenu>
Expand Down
9 changes: 0 additions & 9 deletions packages/html/src/grid/tests/grid-filter-menu-blazor.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterMenu>
Expand Down Expand Up @@ -138,9 +135,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterMenu>
Expand Down Expand Up @@ -208,9 +202,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterMenu>
Expand Down
6 changes: 0 additions & 6 deletions packages/html/src/grid/tests/grid-filter-row-angular.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterRow>
Expand Down Expand Up @@ -193,9 +190,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterRow>
Expand Down
6 changes: 0 additions & 6 deletions packages/html/src/grid/tests/grid-filter-row-blazor.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterRow>
Expand Down Expand Up @@ -245,9 +242,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithFilterRow>
Expand Down
9 changes: 0 additions & 9 deletions packages/html/src/grid/tests/grid-grouping-blazor.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down Expand Up @@ -178,9 +175,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithGrouping>
Expand Down Expand Up @@ -303,9 +297,6 @@ export default () =>(
</GridTable>
</div>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithGrouping>
Expand Down
12 changes: 0 additions & 12 deletions packages/html/src/grid/tests/grid-grouping-detail-template.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down Expand Up @@ -177,9 +174,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithGrouping>
Expand Down Expand Up @@ -302,9 +296,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithGrouping>
Expand Down Expand Up @@ -438,9 +429,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridWithGrouping>
Expand Down
4 changes: 0 additions & 4 deletions packages/html/src/grid/tests/grid-locked-columns-rtl.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</div>
<GridContent>
<div className="k-grid-table-wrap">
Expand Down Expand Up @@ -220,7 +217,6 @@ export default () =>(
</GridTable>
</div>
<div></div>
<div className="k-height-container"><div></div></div>
</GridContent>
</GridContainer>
<GridFooter>
Expand Down
4 changes: 0 additions & 4 deletions packages/html/src/grid/tests/grid-locked-columns.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</div>
<GridContent>
<div className="k-grid-table-wrap">
Expand Down Expand Up @@ -312,7 +309,6 @@ export default () =>(
</GridTable>
</div>
<div></div>
<div className="k-height-container"><div></div></div>
</GridContent>
</GridContainer>
<GridFooter>
Expand Down
6 changes: 0 additions & 6 deletions packages/html/src/grid/tests/grid-multicolumn-headers.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div style={{ height: '0px' }}></div>
</div>
</div>
<GridContent style={{ width: "447px" }}>
<div className="k-grid-table-wrap" style={{ position: "relative" }}>
Expand All @@ -93,9 +90,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div style={{ height: '0px' }}></div>
</div>
</GridContent>
</GridContainer>
</GridWithLockedColumns>
Expand Down
3 changes: 0 additions & 3 deletions packages/html/src/grid/tests/grid-no-records.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div style={{ height: "0px" }}></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down
8 changes: 0 additions & 8 deletions packages/html/src/grid/tests/grid-pager.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
{/* set height to scroll height (virtual scrolling) */}
<div style={{ height: '0px' }}></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down Expand Up @@ -188,10 +184,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
{/* set height to scroll height (virtual scrolling) */}
<div style={{ height: '0px' }}></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down
3 changes: 0 additions & 3 deletions packages/html/src/grid/tests/grid-react-basic.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
</GridNormal>
Expand Down
3 changes: 0 additions & 3 deletions packages/html/src/grid/tests/grid-react.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,6 @@ export default () =>(
</TableTbody>
</GridTable>
</div>
<div className="k-height-container">
<div></div>
</div>
</GridContent>
</GridContainer>
<GridFooter>
Expand Down
Loading

0 comments on commit 23ceb00

Please sign in to comment.