Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show is thread locking on Jupyter Notebook #10

Open
mmhobi7 opened this issue Jun 6, 2022 · 1 comment
Open

show is thread locking on Jupyter Notebook #10

mmhobi7 opened this issue Jun 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mmhobi7
Copy link

mmhobi7 commented Jun 6, 2022

Lenspy seems to be thread locking on Jupyter Notebook.

Side note: There seems to be no way to add multiple figures to the Flask container, or spin new containers without manually doing so.

@mmhobi7 mmhobi7 changed the title show is thread locking show is thread locking on Jupyter Notebook Jun 6, 2022
@serant serant added the enhancement New feature or request label Oct 24, 2022
@serant
Copy link
Collaborator

serant commented Oct 24, 2022

This is a current limitation of lenspy, however it can be improved on by implementing the following:

Preamble: Ideally, lenspy would be integrated into Plotly by utilizing the underlying Javascript events, however this would require modification of the source for plotly-python's codgen to expose events to the Python API.

Instead the following is proposed (I will be working on an implementation similar to the below):

There are three possible environments that a Figure can be deployed in:

  1. Offline plot mode (using plotly.express or plotly.graph_objects directly) (in this environment, we will deploy a Dash server to grant access to the events API provided by Dash to implement lenspy)
  2. Online as part of a Dash app, where a graph server and access to events is possible (therefore we should be using the existing server and Dash's events API to integrate lenspy)
  3. As part of a Jupyter where we should be using FigureWidget to access the event loop of the plot (since FigureWidget utilizes ipywidgets under the hood)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants