Checkstyle seems to be broken

[fgalan]

(Rasied in #151 (comment))

It seems that the checkstyle pass (based in telefonica_checkstyle.xml ruleset) is not working. Although the pom.xml is supposedly configured to use it, it seems that mvn checkstyle:check uses the default sun_checks.xml ruleset.

I did an attemp of fixing it, but not sure if it's ok. I'm including it below, it could be a good starting point.

diff --git a/pom.xml b/pom.xml
index a210429..d8bcaea 100644
--- a/pom.xml
+++ b/pom.xml
@@ -41,7 +41,8 @@
             **/src/main/java/org/json/**, org/json/**
         </sonar.exclusions>
         <sonar.language>java</sonar.language>
-        <sonar.dynamic>reuseReports</sonar.dynamic>
+	<sonar.dynamic>reuseReports</sonar.dynamic>
+	<checkstyle.config.location>telefonica_checkstyle.xml</checkstyle.config.location>
     </properties>
 
     <build>
@@ -121,6 +122,11 @@
                 <configuration>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.0.0</version>
+            </plugin>
         </plugins>
     </build>
     <reporting>
@@ -146,9 +152,7 @@
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <version>3.0.0</version>
                 <configuration>
-                    <configLocation>telefonica_checkstyle.xml</configLocation>
-                    <includeTestSourceDirectory>false</includeTestSourceDirectory>
-                    <failOnViolation>false</failOnViolation>
+		    <configLocation>telefonica_checkstyle.xml</configLocation>
                 </configuration>
             </plugin>
             <plugin>
diff --git a/telefonica_checkstyle.xml b/telefonica_checkstyle.xml
index 5a6539e..1dfab02 100644
--- a/telefonica_checkstyle.xml
+++ b/telefonica_checkstyle.xml
@@ -196,7 +196,7 @@
         <module name="MagicNumber"/>
         -->
         <module name="MissingSwitchDefault"/>
-        <module name="RedundantThrows"/>
+        <!--module name="RedundantThrows"/-->
         <module name="SimplifyBooleanExpression"/>
         <module name="SimplifyBooleanReturn"/>
 
@@ -229,4 +229,4 @@
         </module>
     </module>
 
-</module>
\ No newline at end of file
+</module>

Ideally, checkstyle should be included in .travis.yml.