Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test has been disabled due to request-shim-update #259

Open
jason-fox opened this issue Dec 22, 2021 · 0 comments
Open

Failing test has been disabled due to request-shim-update #259

jason-fox opened this issue Dec 22, 2021 · 0 comments

Comments

@jason-fox
Copy link
Contributor

The following test has been disabled:

test/unit/ngsiv2/registration-test.js

+                    /*ngsiClient.getRegistrations('TestClient:Light', 'Light', undefined, function (
                        error,
                        response,
                        body
                    ) {
                        should.not.exist(error);
                        should.exist(body);
                        response.statusCode.should.equal(200);
-                        let registrations = JSON.parse(body);
-                        registrations.length.should.equal(0);
-                       done();
-                    });
+                        body.length.should.equal(0);*/
+                    done();
+                    /*});*/

The reasoning is as follows:

Because ngsiClient was calling an NGSI-v1 function, and after the switch to NGSI-v2 and got, it still doesn't work 😄

This is a test expectation using an HTTP request to check some things which assume the request was made by the obsolete
request library - I guess it is the same situation as JSON body length thing.

Progress the request-shim refactoring the following workaround has been implemented: see #255 (comment)

  • Create an issue about this, explaining the situation (the text in the comment above could be useful)
  • Disable de case using xit() with a code comment FIXME referring the issue number created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant