[TEP-0144] Param Enum - Implementation

[QuanZhang-William]

In TEP-0144, we introduced a new Enum field to enable Tekton built-in param input validation.

This is the umbrella issue to tracking all the implementation work.

Implementation

• Add enable-param-enum feature flag
  • [TEP-0144] Add feature flag and doc placeholder #7279
• Introduce Param.Enum API fields, validation and conversion webhooks
  • [TEP-0144] Add enum API field #7289
• Implement TaskRun validation against Param.Enum
  • [TEP-0144] Validate TaskRun for Param Enum #7326
• Implement PipelineRun validation against Param.Enum
  • [TEP-0144] Validate PipelineRun for Param Enum #7338

Promotion Feedback Issue:

• Feedback/beta release for TEP-0144: Param Enum #7410

[QuanZhang-William]

/assign

[QuanZhang-William]

This feature is implemented and will be available in v0.54 release!

/close

[dohoangkhiem]

Hey, this is causing issues after we upgraded to latest Tekton Pipeline, with enable-param-enum set to true.

This line 8a8c0c3#diff-39d9baa708e379638f742c8b9fd36d9d15c64c3386de958b5a3f309ca8fa037aR825 does not work in case of task param value is a script which referenced multiple pipeline params.

For example, this is the task in the pipeline

    - name: push-s3
      runAfter:
        - install-build
      taskRef:
        name: aws-cli
      workspaces:
        - name: source
          workspace: shared-data
      params:
        - name: SCRIPT
          value: |
            # this is to avoid aws-cli permission denied error on /.aws
            export HOME=/tmp/.aws
            aws s3 sync $(workspaces.source.path)/$(context.pipelineRun.name)/dist/ s3://$(params.s3-bucket)/$(params.s3-path) --delete --region $(params.aws-region) --debug

will result to
unexpected resolved param in ExtractVariablesFromString, expect 1 but got 3

The same error could happen to any task parameter value that is combined from more than 1 pipeline params' values.

@QuanZhang-William