Merge pull request #824 from dhensby/pulls/4/dont-modify-config-obj

Dont modify the passed in config object
tediousjs · Mar 8, 2019 · c4e939d · c4e939d
2 parents 1d31ad6 + 155c5c2
commit c4e939d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/base.js b/lib/base.js
@@ -122,19 +122,20 @@ class ConnectionPool extends EventEmitter {
     IDS.add(this, 'ConnectionPool')
     debug('pool(%d): created', IDS.get(this))
 
-    this.config = config
     this._connected = false
     this._connecting = false
 
-    if (typeof this.config === 'string') {
+    if (typeof config === 'string') {
       try {
-        this.config = ConnectionString.resolve(this.config, driver.name)
+        this.config = ConnectionString.resolve(config, driver.name)
       } catch (ex) {
         if (typeof callback === 'function') {
           return callback(ex)
         }
         throw ex
       }
+    } else {
+      this.config = Object.assign({}, config)
     }
 
     // set defaults