Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Test] EC2 Tests need some more setup before we can fully test this module #30

Open
evanjtravis opened this issue Nov 12, 2019 · 1 comment

Comments

@evanjtravis
Copy link
Contributor

Several configuration flavors of ecs-service require the use of EC2 instances, the creation of which is not currently supported by the test engine. This causes the tests to fail.

The Dockerfile for testing this module has a modified ENTRYPOINT to exclude any tests that require the creation of an EC2 instance. This change can be reverted once we have a working solution to this issue.

Some proposed solutions:

  1. Create an EC2 box that doesn't do anything but support temporary ecs-service instances.
  2. Modify the test engine to spin up a temporary EC2 instance associated with the ECS cluster, and then destroy the EC2 at the conclusion of tests.
@evanjtravis
Copy link
Contributor Author

For whatever reason, the modified ENTRYPOINT is causing behave to skip ALL tests, so for right now the kludgy solution is to comment out the offending tests. This issue will be resolved once we un-comment
the tests and they can run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant