Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove confetti from print preview #27

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

aeschi
Copy link
Contributor

@aeschi aeschi commented Feb 12, 2024

@aeschi aeschi requested a review from raphael-arce as a code owner February 12, 2024 13:14
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buergeramt-goes-digital ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 3:13pm

Copy link
Contributor

@raphael-arce raphael-arce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question, otherwise LGTM 👍 thanks :)

font-family: "Berlin";
font-style: normal;
font-weight: 400;
src: url("/fonts/BerlinTypeWeb-Regular.woff2");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops. thanks for fixing this! I didn't know my config for prettier was ignoring css files.

src/index.css Outdated

@media print {
canvas {
display: none !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question out of curiosity, why is the !important property necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point - it's not necessary. I will take it out.

@aeschi aeschi merged commit 73b3187 into main Feb 13, 2024
4 checks passed
@raphael-arce raphael-arce deleted the fix/remove-confetti-from-print branch February 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants