-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove confetti from print preview #27
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question, otherwise LGTM 👍 thanks :)
font-family: "Berlin"; | ||
font-style: normal; | ||
font-weight: 400; | ||
src: url("/fonts/BerlinTypeWeb-Regular.woff2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops. thanks for fixing this! I didn't know my config for prettier was ignoring css files.
src/index.css
Outdated
|
||
@media print { | ||
canvas { | ||
display: none !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question out of curiosity, why is the !important
property necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point - it's not necessary. I will take it out.
https://app.asana.com/0/1206159861069468/1206391318667095/f