generated from technologiestiftung/template-repo-citylab
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add link for typeform datenschutz and impressum #25
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2a288dd
feat: add link for typeform datenschutz and impressum
aeschi 8a506e5
feat: exchange german tag with variable
aeschi fcfad09
feat: refactor feedback and footer to components
aeschi 5fee5cc
fix: exchange imprint link and data privacy name
aeschi b73b48e
feat: change all link colors to blue-700
aeschi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { t } from "../../i18n/translations"; | ||
| import { useI18nStore } from "../../i18n/store"; | ||
| import { availableLanguages } from "../../../src/i18n/store/types"; | ||
|
|
||
| export function Feedback() { | ||
| const language = useI18nStore((state) => state.language); | ||
|
|
||
| return ( | ||
| <> | ||
| {language === availableLanguages[0] && ( | ||
| <div className="flex w-full flex-wrap justify-center gap-x-2 px-8 py-4 text-sm"> | ||
| {t("feedback.question", language)} | ||
| <a | ||
| className="text-blue-500 underline" | ||
| href={t("feedback.link", language)} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {t("feedback.link.label", language)} | ||
| </a> | ||
| </div> | ||
| )} | ||
| </> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { t } from "../../i18n/translations"; | ||
| import { useI18nStore } from "../../i18n/store"; | ||
| import { useProgressStore } from "../steps/store"; | ||
|
|
||
| export function Footer() { | ||
| const language = useI18nStore((state) => state.language); | ||
| const currentStep = useProgressStore((state) => state.currentStep); | ||
|
|
||
| return ( | ||
| <footer | ||
| className={`flex py-4 | ||
| ${currentStep === 0 || currentStep === 16 ? "flex" : "hidden md:flex"} | ||
| `} | ||
| id="footer" | ||
| > | ||
| <div className="flex w-full flex-wrap justify-start gap-y-5"> | ||
| <div className="flex w-full flex-wrap justify-start gap-x-10 gap-y-5 px-8 py-2 text-sm sm:justify-center md:gap-x-20 md:px-5"> | ||
| <div className="flex flex-col gap-4"> | ||
| {t("logo.t1", language)} | ||
| <img | ||
| src="/images/logo-citylab-berlin-outline.svg" | ||
| alt="Logo von CityLab Berlin" | ||
| className="w-32" | ||
| loading="lazy" | ||
| /> | ||
| </div> | ||
| <div className="flex flex-col gap-4"> | ||
| {t("logo.t2", language)} | ||
| <img | ||
| src="/images/logo-technologiestiftung-berlin-de.svg" | ||
| alt="Logo von Technologiestiftung Berlin" | ||
| className="w-32" | ||
| loading="lazy" | ||
| /> | ||
| </div> | ||
| <div className="flex flex-col gap-4"> | ||
| {t("logo.t3", language)} | ||
| <img | ||
| src="/images/logo-senatskanzlei-buergermeister-vertikal.svg" | ||
| alt="Logo von Berlins Regierender Bürgermeister" | ||
| className="w-28" | ||
| loading="lazy" | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div className="flex w-full flex-wrap justify-center gap-x-5 px-5 text-sm "> | ||
| <a | ||
| className="flex flex-col gap-4 text-gray-400 underline" | ||
| href="https://www.technologiestiftung-berlin.de/datenschutz" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {t("dataPrivacy", language)} | ||
| </a> | ||
| <a | ||
| className="flex flex-col gap-4 text-gray-400 underline" | ||
| href={t("imprint.link", language)} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {t("imprint", language)} | ||
| </a> | ||
| </div> | ||
| </div> | ||
| </footer> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aeschi just noticed that this is not the same color than other links, the other links are
text-blue-700to have enough contrastThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, my bad, I only I compared it with the download links on the checklist overview page. The link colors are inconsistent, sometimes 500, sometimes 700. Should we stick to one? Or does it make sense to go for a darker tone when the backgground is darker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to stick to one color with the most contrast and check again for the darker backgrounds. But technically a darker background would be better with a brighter text color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree 👍