feat: add link for typeform datenschutz and impressum #25
Conversation
aeschi
commented
Feb 8, 2024
•
aeschi
commented
- typeform link only shows when german is selected
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1206391193889875
- typeform link only shows when german is selected
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/App.tsx
Outdated
| @@ -31,6 +34,20 @@ function App() { | |||
| <Steps /> | |||
| </main> | |||
|
|
|||
| {language === availableLanguages[0] && ( | |||
There was a problem hiding this comment.
I think we should rather use a named variable here, e.g. availableLanguages['de-DE], to make it easier to understand which language is used, and also to make sure no type error occurs. I looked a bit into it and realized the current state of implementation won't allow it. I think we'd need to use zod native enums instead of zod enums to type the availableLanguages. This is probably a bigger change than what is scoped in this ticket so maybe we can discuss and prioritize it first before implementing it.
src/App.tsx
Outdated
| Beantworte uns gerne einige Fragen. | ||
| </a> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
I think it would make sense to move what is above in its own component, e. g. <Feedback />👍
src/App.tsx
Outdated
| rel="noopener noreferrer" | ||
| > | ||
| Impressum | ||
| </a> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Same here. Maybe let's move what is above in its own component (e.g. <Footer />) to keep the App.tsx short and easy to understand.
- removed footer and feedback from App.tsx to individual components - added all text sections to translation.json for clean structure
|
thanks 👍 lgtm! |
src/components/feedback/index.tsx
Outdated
| <div className="flex w-full flex-wrap justify-center gap-x-2 px-8 py-4 text-sm"> | ||
| {t("feedback.question", language)} | ||
| <a | ||
| className="text-blue-500 underline" |
There was a problem hiding this comment.
@aeschi just noticed that this is not the same color than other links, the other links are text-blue-700 to have enough contrast
There was a problem hiding this comment.
Woops, my bad, I only I compared it with the download links on the checklist overview page. The link colors are inconsistent, sometimes 500, sometimes 700. Should we stick to one? Or does it make sense to go for a darker tone when the backgground is darker?
There was a problem hiding this comment.
Let's try to stick to one color with the most contrast and check again for the darker backgrounds. But technically a darker background would be better with a brighter text color.
