Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug and deprecation of feature in nacl library which existing implementation of telnyx webhook.py relies on #52

Closed
mattsdevop opened this issue May 10, 2021 · 1 comment

Comments

@mattsdevop
Copy link

mattsdevop commented May 10, 2021

Python 3.8.5
I experienced this issue pyca/pynacl#525 while testing https://github.com/team-telnyx/telnyx-python/blob/master/telnyx/webhook.py
I used pip3 install --upgrade telnyx to install latest. It looks like this is a known bug that they don't plan to fix. There is a PR prepared that deprecates the encoder= option from pynacl pyca/pynacl#523.

Unfortunately, since it's a requirement to use the same encoder= option that was used to sign, it isn't possible to remove this on the receiving endpoint of the webhook call. It would need to be updated on the signing side.

Suggest using encoder = encoding.RawEncoder on the signing side before calling webhook remote server so that the endpoint can use the same.

To be explicit: this is currently preventing webhooks from working as they are described in the documentation. And blocking any implementation.

@d-telnyx
Copy link
Contributor

@mattsdevop We're looking into this now. We don't use python on our server side so we're investigating the whole solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants