Redirect isSteppingCarefully for better sponge compatibility #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmellyModder
requested changes
Mar 7, 2022
src/main/java/com/minecraftabnormals/abnormals_core/core/mixin/EntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/minecraftabnormals/abnormals_core/core/mixin/EntityMixin.java
Outdated
Show resolved
Hide resolved
| @Shadow | ||
| private World level; | ||
| public World level; |
There was a problem hiding this comment.
Keep this private.
Suggested change
| public World level; | |
| private World level; |
There was a problem hiding this comment.
but the field itself is public, Shadows should normally retain the same access level as their targets, regardless whether their intended uses are internal or external to the mixin in question.
|
Thanks for the fix. I'll also port the fix to 1.18.2 when we finish the port. |
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
SmellyModder
approved these changes
Mar 8, 2022
|
has this been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #135
As suggested in SpongePowered/Sponge#3514 (comment)