Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop grpc-web for all interfaces #734

Open
altafan opened this issue Sep 13, 2023 · 0 comments
Open

Drop grpc-web for all interfaces #734

altafan opened this issue Sep 13, 2023 · 0 comments
Assignees

Comments

@altafan
Copy link
Contributor

altafan commented Sep 13, 2023

At the moment the daemon can be reached with grpc, grpc-web but also via rest thanks to grpc-gateway and google api annotations. grpc-web and rest basically overlap (even though they are not so similar technically) so we can safely drop one of the 2.

Let's drop grpc-web in favor of grpc-gateway. This means adding api annotations to the daemon protos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant