Editorial: add a 'decode a list of base64 VLQ' algorithm #130
+23
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Sep 26, 2024
jridgewell
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Can we keep the optional error for a non-1/4/5 length segment?
My code will be slightly out of spec since we'll eat the , as a 0 value and continue reading values from the next segment. I see if I can instead limit my position to < commaIndex without adding more checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts a 'decode a list of base64 VLQ' algorithm that consumes a string wholly and returns all contained VLQ numbers as a list. We can share this algorithm between decoding
mappingsandoriginalScopes/generatedRangesof the scopes proposal.It also makes the algorithm slightly more readable as we can get rid of
positionand we don't necessarily need therelative*variables as they only have a single use-site.