From cea4332e648c65c5c32973d7837ca52e57f89859 Mon Sep 17 00:00:00 2001 From: tboldagh Date: Fri, 14 Jan 2022 09:05:06 +0100 Subject: [PATCH] Docu update --- README.md | 6 +++--- tests/test_lfv.cpp | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 3c839b7..b18e0db 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ # FunRootAna -This is basic framework allowing to do [ROOT](https://root.cern.ch/) analysis in a more functional way. +This is a basic framework allowing to do [ROOT](https://root.cern.ch/) analysis in a more functional way. In comparison to RDFrame it offers more functional feel for the data analysis (in particular histograms filling) and is overall a bit more holistic. -As consequence, typical a single line containing selection, data extraction & histogram definition is sufficient to obtain one unit of result. +As consequence, a single line containing selection, data extraction & histogram definition is sufficient to obtain one unit of result (one histogram). The promise is: @@ -48,7 +48,7 @@ As a result of running that code over the TTree, histograms are made and saved i -# Grouping a related info +# Analysis objects Now think that we would like to treat the `x,y,z` as a whole, in the end they represent one object, a point in 3D space. We need to do this with plain Ntuples but if the TTree contains object already then the functionality comes for free. So let's make the points look like objects. For that we would need to create a structure to hold the three coordinates together (we can also use the class but we have no reason for it here). diff --git a/tests/test_lfv.cpp b/tests/test_lfv.cpp index 5e8eb18..0539e49 100644 --- a/tests/test_lfv.cpp +++ b/tests/test_lfv.cpp @@ -251,7 +251,7 @@ void test_enumerate() { // this is failing and needs upgrade of foreach auto sen1 = en1.stage().sorted(F(_.second)).stage(); - + // TODO figure out why staging was needed after sort VALUE( sen1.element_at(0).value().second) EXPECTED(-1); VALUE( sen1.element_at(0).value().first) EXPECTED(5); } @@ -273,7 +273,7 @@ void test_reversal() { auto s1 = r1.sorted(); VALUE(s1.element_at(0).value()) EXPECTED(-1); - // double reverse + // double reversescala auto r2 = r1.reverse(); VALUE(r2.element_at(1).value()) EXPECTED(19);