Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvement: more informative error handling for facetsSuite::ccf_annotate_maf #2

Open
ndfriedman opened this issue Jan 10, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ndfriedman
Copy link

ndfriedman commented Jan 10, 2020

I've noticed that facetsSuite::ccf_annotate_maf fails when in a couple of cases (purity=NA, no mutations in the maf) with an identical uninformative error:

Error in if (is.na(total_copies)) { : argument is of length zero Calls: <Anonymous> -> [ -> [.data.table -> expected_mutant_copies Execution halted

It would be helpful if instead we got a message about facets not being able to estimate a purity, having 0 mutations etc and that the program would either fail with an error or return an unannotated maf

@ndfriedman ndfriedman added the enhancement New feature or request label Jan 10, 2020
@ndfriedman ndfriedman changed the title small improvement: more informative error handling for cases with purity=NA small improvement: more informative error handling for facetsSuite::ccf_annotate_maf Jan 10, 2020
rptashkin added a commit that referenced this issue Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant