Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.3 and Taxjar\SalesTax\Model\Import\Rate #380

Open
3 tasks
vovk404 opened this issue Dec 12, 2024 · 0 comments
Open
3 tasks

php 8.3 and Taxjar\SalesTax\Model\Import\Rate #380

vovk404 opened this issue Dec 12, 2024 · 0 comments

Comments

@vovk404
Copy link

vovk404 commented Dec 12, 2024

Description

class vendor/taxjar/module-taxjar/Model/Import/Rate.php:100 is not supporting PHP 8.3, because of the line:
$this->_calculationFactory = $calculationFactory;
in the constructor

Steps to Reproduce

  1. Enable taxjar for the checkout in the Stores->Configuration->Sales->Tax:: Enabled for Checkout
  2. reload the page or have it enabled in the admin and open the page.

Expected Result

render configs page in the admin, should be visible

Actual Result

empty page instead of configs.

Versions

  • Magento 2.4
  • Magento Open Source (fka Magento 2 Community Edition)
  • PHP 8.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant