Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin order sync status is incorrect #369

Open
rhoerr opened this issue Dec 6, 2023 · 0 comments
Open

Admin order sync status is incorrect #369

rhoerr opened this issue Dec 6, 2023 · 0 comments

Comments

@rhoerr
Copy link

rhoerr commented Dec 6, 2023

Magento version 2.4.6-p3
TaxJar extension version 2.2.0 (current release)

Viewing an admin order and then going to 'TaxJar Information' should show 'Last synced at {date}' if an order has synced. Instead, it always shows "This order has not been synced to TaxJar."

Steps to reproduce

  1. Have a completed synced order
  2. Go to Admin > Sales > Orders and view the order
  3. See that the Information tab shows "Synced to TaxJar" with a sync date
  4. Click the TaxJar Information tab, and open the Sync Status section
  5. See that it shows "This order has not been synced to TaxJar."

Tech details

The issue is related to

$formattedDate = $block->getFormattedSyncDate($order);

There's no such getFormattedSyncDate method in the block. That causes the template to fail to obtain the sync date, and decide the order is unsynced.

It should be easily fixed by adding getFormattedSyncDate to https://github.com/taxjar/taxjar-magento2-extension/blob/ece47270a7e6b319031e95529c303c5317797a0a/Block/Adminhtml/Order/View/Tab/Taxjar/View/Info/Sync.php .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant