Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set connectTimeout from Init #851

Closed
wants to merge 0 commits into from
Closed

set connectTimeout from Init #851

wants to merge 0 commits into from

Conversation

hygkui
Copy link
Contributor

@hygkui hygkui commented Dec 25, 2023

No description provided.

@hygkui hygkui requested a review from a team as a code owner December 25, 2023 14:38
@amrbashir
Copy link
Member

Could you add a change file in .changes directory?

@hygkui
Copy link
Contributor Author

hygkui commented Dec 27, 2023

Could you add a change file in .changes directory?

Yes, it's done.

amrbashir
amrbashir previously approved these changes Dec 27, 2023
@amrbashir
Copy link
Member

Thanks

@amrbashir
Copy link
Member

looks like you need to run pnpm build

@hygkui
Copy link
Contributor Author

hygkui commented Dec 28, 2023

looks like you need to run pnpm build

Got it!

amrbashir
amrbashir previously approved these changes Dec 28, 2023
@amrbashir
Copy link
Member

@hygkui your last commit 486cfe1 (#851) is not signed and I won't be able to merge now

@hygkui
Copy link
Contributor Author

hygkui commented Dec 28, 2023

Ok, I will fix it.

@hygkui
Copy link
Contributor Author

hygkui commented Dec 28, 2023

@amrbashir Thanks for your help, I think all is good this time :)

@amrbashir
Copy link
Member

@hygkui unfortunately the commit still exists, you need to rebase and squash that commit or sign it.

@hygkui
Copy link
Contributor Author

hygkui commented Dec 28, 2023

@hygkui unfortunately the commit still exists, you need to rebase and squash that commit or sign it.

OK

@hygkui hygkui closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants