Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(fs): improve FileHandle.read performance #1950

Merged
merged 5 commits into from
Oct 20, 2024
Merged

perf(fs): improve FileHandle.read performance #1950

merged 5 commits into from
Oct 20, 2024

Conversation

amrbashir
Copy link
Member

No description provided.

@amrbashir amrbashir requested a review from a team as a code owner October 18, 2024 14:14
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Package Changes Through fa69c6c

There are 12 changes which include dialog with patch, dialog-js with patch, positioner with patch, positioner-js with patch, fs with patch, fs-js with patch, http with patch, http-js with patch, shell with patch, shell-js with patch, store-js with minor, store with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.2 2.0.3
api-example-js 2.0.0 2.0.1
fs 2.0.1 2.0.2
fs-js 2.0.0 2.0.1
dialog 2.0.1 2.0.2
dialog-js 2.0.0 2.0.1
http 2.0.1 2.0.2
http-js 2.0.0 2.0.1
persisted-scope 2.0.1 2.0.2
positioner 2.0.1 2.0.2
positioner-js 2.0.0 2.0.1
shell 2.0.1 2.0.2
shell-js 2.0.0 2.0.1
store 2.0.1 2.1.0
store-js 2.0.0 2.1.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir
Copy link
Member Author

converted into draft for now, as I think there is more optimizations I can add

@lucasfernog lucasfernog merged commit ae80245 into v2 Oct 20, 2024
36 checks passed
@lucasfernog lucasfernog deleted the perf/fs branch October 20, 2024 11:49
@bWanShiTong
Copy link
Contributor

This breaks compilation for systems target_pointer_width of 16 and 32:

    #[cfg(target_pointer_width = "16")]
    let nread = {
        let nread = nread.to_be_bytes();
        let mut out = [0; 8];
        out[6..].copy_from_slice(&nread);
    };
    #[cfg(target_pointer_width = "32")]
    let nread = {
        let nread = nread.to_be_bytes();
        let mut out = [0; 8];
        out[4..].copy_from_slice(&nread);
    };
    #[cfg(target_pointer_width = "64")]
    let nread = nread.to_be_bytes();

It should be:

    #[cfg(target_pointer_width = "16")]
    let nread = {
        let nread = nread.to_be_bytes();
        let mut out = [0; 8];
        out[6..].copy_from_slice(&nread);
        out
    };
    #[cfg(target_pointer_width = "32")]
    let nread = {
        let nread = nread.to_be_bytes();
        let mut out = [0; 8];
        out[4..].copy_from_slice(&nread);
        out
    };
    #[cfg(target_pointer_width = "64")]
    let nread = nread.to_be_bytes();

Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this pull request Oct 22, 2024
* perf(fs): improve `FileHandle.read` performance

* handle different target pointer width

* improve `writeTextFile` performance

* revert packageManager field

* change file

---------

Co-authored-by: Lucas Nogueira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants