Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelTrait not compactable with BaseModel CI4.5 #51

Open
seunex17 opened this issue Apr 23, 2024 · 8 comments
Open

ModelTrait not compactable with BaseModel CI4.5 #51

seunex17 opened this issue Apr 23, 2024 · 8 comments

Comments

@seunex17
Copy link
Contributor

This package does not seem to work for Codeigniter V4.5

@vonboth
Copy link

vonboth commented May 5, 2024

@MGatner
Can you pls. update this package to work with CI4.5? Thank you!

@seunex17
Copy link
Contributor Author

seunex17 commented May 5, 2024

@vonboth i already fix this and send a pull request maybe he can check.
#52

@damian-romanowski
Copy link

Can we get a semver release now that #52 has been merged in?

Composer is still on v2.1.1.

@vonboth
Copy link

vonboth commented Jul 23, 2024

@MGatner
Can you please create a new release?

@vonboth
Copy link

vonboth commented Aug 7, 2024

@MGatner
Can I support you somehow with the upgrade? What is missing?

Because you said you don't use the project any longer would you like to give it to someone else?

@MGatner
Copy link
Collaborator

MGatner commented Aug 15, 2024

I'm sorry for the delay. I went to make the release and got stuck trying to fix pipeline errors. I think the issues aren't relevant, so I'll put the question to you all who are actively using this: ignore the pipeline errors and proceed with release, or someone dig into the issues blocking the pipeline?

@damian-romanowski
Copy link

The issues don't seem relevant.

I've been patching my installs with sed -i 's/findAll(int $limit = 0, int $offset = 0)/findAll(int $limit = null, int $offset = 0)/g' vendor/tatter/relations/src/Traits/ModelTrait.php after composer install and all works fine on ^4.5.

@vonboth
Copy link

vonboth commented Aug 19, 2024

I agree with you both. It doesn't seem to be relevant. So I 'd appreciate to see a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants