Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger should not be mutated #28

Open
choubacha opened this issue Jan 14, 2020 · 0 comments
Open

Logger should not be mutated #28

choubacha opened this issue Jan 14, 2020 · 0 comments

Comments

@choubacha
Copy link

When we pass the logger to the client we end up changing the log level:

https://github.com/taskrabbit/waistband/blob/master/lib/waistband/index.rb#L279

The issue arises that this is a mutation on a logger instance that has not been defensively copied, therefore we're changing the logger for every instance.

This is likely not threadsafe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant