Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move diagram generation, transition rates setting etc. to KineticModel #144

Open
dburov190 opened this issue Jun 25, 2020 · 0 comments
Open

Comments

@dburov190
Copy link
Collaborator

Currently (i.e. after #136), ContactNetwork accepts transition rates for KineticModel; however, transition rates for MasterEquationEnsemble are set separately. This creates confusion, so it's better to either

  • set transition rates inside KineticModel without ever touching ContactNetwork (through a factory method), or
  • set true transition rates on ContactNetwork, and then let the ensemble read those that are needed, and pass distributions for those that have to be inferred via EAKF.

Besides, generate_diagram_indep and generate_diagram_neigh methods are inside ContactNetwork simply because of the names of weight labels; they don't really belong there. This can be fixed via a Glossary class which would hold all parameter names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant