Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add note to favorite animation #511

Open
Bartek532 opened this issue May 31, 2021 · 6 comments · May be fixed by #539 or #553
Open

[Feature] Add note to favorite animation #511

Bartek532 opened this issue May 31, 2021 · 6 comments · May be fixed by #539 or #553
Labels
Type: Feature New feature or request

Comments

@Bartek532
Copy link
Contributor

Bartek532 commented May 31, 2021 •
edited
Loading

Problem
When user add note to favorites, only star is added to note, personally, first time I missed it, so I think user should get a clearer signal

Solution
Make some kind of animation with star to let user know, that their note has been added to your favorites
@Bartek532 Bartek532 added the Type: Feature New feature or request label May 31, 2021
@Parteeksachdeva
Copy link

How do you want it? I tested it it's showing a star after bookmarking a note. Do you want to change it to some kind of animation?

@Bartek532
Copy link
Contributor Author

Yep, I think the animation will be the best, but I am not entirely sure what it should look like 😛

@sayna3311
Copy link

Will it be better, if the star turned in came to its place?

@Bartek532
Copy link
Contributor Author

Hmm, maybe 😛

@sayna3311
Copy link

Should I implement this and send a PR?

@Bartek532
Copy link
Contributor Author

Yeah 👍

@pierreericgarcia pierreericgarcia linked a pull request Nov 14, 2021 that will close this issue
Open
4 tasks
@prajwalkulkarni prajwalkulkarni linked a pull request Jan 28, 2022 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@Parteeksachdeva @Bartek532 @sayna3311