Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Pass balance value from caller to the msg.value in EVM Hooks. #818

Closed
shekohex opened this issue Nov 11, 2024 · 2 comments
Closed
Assignees
Labels
feature ➕ Tasks that are functional additions or enhancements p1 🟠 task ✔️

Comments

@shekohex
Copy link
Contributor

Currently, we hard-coded Zero value to the EVM call in hooks everywhere here:

let info =
Self::evm_call(Self::address(), contract, U256::from(0), data, gas_limit)?;
(info.exit_reason.is_succeed(), Self::weight_from_call_info(&info))
and other places. We should allow the caller to specify how much TNT or any other asset, by assetId, and amount to be passed to the Blueprint manager, which would be translated to an ERC20 Token address and amount. This value is automatically deduced from the caller account and got transferred to the BlueprintManager smart contract balance.

@shekohex shekohex added feature ➕ Tasks that are functional additions or enhancements p1 🟠 task ✔️ labels Nov 11, 2024
@shekohex shekohex self-assigned this Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Not Started 🕧 in Webb Universe Nov 11, 2024
@shekohex
Copy link
Contributor Author

Also this, do not forget to update and create a PR to tnt-core with these changes.

@shekohex
Copy link
Contributor Author

Could be combined with #817

@shekohex shekohex moved this from Not Started 🕧 to Building 🏗️ in Webb Universe Nov 13, 2024
@github-project-automation github-project-automation bot moved this from Building 🏗️ to Completed ✅ in Webb Universe Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ➕ Tasks that are functional additions or enhancements p1 🟠 task ✔️
Projects
Status: Completed ✅
Development

No branches or pull requests

1 participant