Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Maven 3.3.2 changed a bit things #5

Open
cstamas opened this issue Feb 22, 2024 · 0 comments
Open

Problem: Maven 3.3.2 changed a bit things #5

cstamas opened this issue Feb 22, 2024 · 0 comments

Comments

@cstamas
Copy link
Member

cstamas commented Feb 22, 2024

That results that dependencies without versions (even if "validator" we replace passed it thru) makes the build fail:
apache/maven@618e62d#diff-a50ddacb3dedf77caed875fe97b242d3d2a222a503aaf07ca7394da7bf750a38

Here a switch was made from nullcheck to commons-lang nonblank.

Hence, io.takari.maven.targetplatform.IntegrationTest#testNonstrictMixed makes fail with:

.[1;31mjava.lang.IllegalArgumentException.[m: .[1;31mversion can neither be null, empty nor blank.[m
    .[1mat.[m org.apache.commons.lang3.Validate.notBlank (.[1mValidate.java:454.[m)
    .[1mat.[m org.apache.maven.artifact.ArtifactUtils.notBlank (.[1mArtifactUtils.java:107.[m)
    .[1mat.[m org.apache.maven.artifact.ArtifactUtils.key (.[1mArtifactUtils.java:97.[m)
    .[1mat.[m org.apache.maven.ReactorReader.findArtifact (.[1mReactorReader.java:101.[m)
    .[1mat.[m org.eclipse.aether.util.repository.ChainedWorkspaceReader.findArtifact (.[1mChainedWorkspaceReader.java:97.[m)
    .[1mat.[m org.apache.maven.internal.aether.MavenChainedWorkspaceReader.findArtifact (.[1mMavenChainedWorkspaceReader.java:81.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (.[1mDefaultArtifactResolver.java:306.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (.[1mDefaultArtifactResolver.java:229.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact (.[1mDefaultArtifactResolver.java:207.[m)
    .[1mat.[m io.takari.maven.targetplatform.FilteredArtifactResolver.resolveArtifact (.[1mFilteredArtifactResolver.java:57.[m)
    .[1mat.[m org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom (.[1mDefaultArtifactDescriptorReader.java:240.[m)
    .[1mat.[m org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor (.[1mDefaultArtifactDescriptorReader.java:171.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.resolveCachedArtifactDescriptor (.[1mDefaultDependencyCollector.java:538.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.getArtifactDescriptorResult (.[1mDefaultDependencyCollector.java:523.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (.[1mDefaultDependencyCollector.java:410.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (.[1mDefaultDependencyCollector.java:362.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (.[1mDefaultDependencyCollector.java:349.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (.[1mDefaultDependencyCollector.java:506.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (.[1mDefaultDependencyCollector.java:458.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (.[1mDefaultDependencyCollector.java:362.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (.[1mDefaultDependencyCollector.java:349.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies (.[1mDefaultDependencyCollector.java:254.[m)
    .[1mat.[m org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies (.[1mDefaultRepositorySystem.java:284.[m)
    .[1mat.[m org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (.[1mDefaultProjectDependenciesResolver.java:170.[m)
    .[1mat.[m org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (.[1mLifecycleDependencyResolver.java:266.[m)
cstamas added a commit that referenced this issue Feb 27, 2024
Resurrect the project, make it work with Maven 3.8.8 and 3.9.6

Note: this PR applies upcoming Takari Parent POM 53 changes as well (but uses released 52): sources and headers are 
formatted.

Changes:
* just bring parent and tooling up to date
* GH dependabot + CI
* mvnw updated
* slight changes to make it work
* updates of upstream Takari dependencies
* one issue: #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant