Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Increase test coverage #12

Open
olivierobert opened this issue Nov 28, 2023 · 0 comments · Fixed by #17
Open

[Chore] Increase test coverage #12

olivierobert opened this issue Nov 28, 2023 · 0 comments · Fixed by #17
Assignees

Comments

@olivierobert
Copy link

Issue

Automated tests do not sufficiently cover the core business logic of scraping.

Expected

While 100% test coverage is not required for this code challenge, all critical paths of the application should be unit-tested (and, ideally, UI-tested). So the following should be better covered:

  • Keyword creation
  • Keyword scraping
  • Keyword listing

Note

Writing tests for a class that makes a network request is challenging, that is why it an expectation from our side to assess how you approach such a technical challenge.

@tajul-saajan tajul-saajan self-assigned this Nov 29, 2023
@tajul-saajan tajul-saajan linked a pull request Nov 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants