-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What's the purpose of specifiedByUrl ? #275
Comments
It's just better documentation. How specifically is it breaking? It sounds like the directive is just getting ignored in your case, which doesn't seem like an issue to me? |
I am using apollo client to generate typescript types from schema and queries. The tool fails now with an error |
I'm not sure why the file size of the GraphQL schema matters. In general, if you're running the appropriate build steps, I don't think it should get shipped to clients. I'm also not sure that this is a matter of this schema per se... does the spec say somewhere that it's impermissible to add these? It seems more like this is something opted into by e.g. an upgrade to |
I'm also getting this error when upgraded this lib to GraphQLSchemaValidationError: Unknown directive "specifiedBy" |
+1, also getting this |
I'm getting error when use apollo codegen to client side following this error 😞
|
The |
It is a breaking change.
I am using
apollo
+type-graphql
setup and it seems the setup is not compatible withspecifiedBy
directive out of the box, as it's not outputingspecifedBy
directive definition without touching up here and there.What are the benefits of having the directive that it requires touching up and it also increases size of
schema.graphql
file?The text was updated successfully, but these errors were encountered: