-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allow(clippy::missing_docs_in_private_items)
#356
Conversation
49c7a47
to
5bf562b
Compare
Thanks! Could you add a case that triggers this to tests/lint.rs test? |
5bf562b
to
75fa3f7
Compare
The lint apparently doesn't trigger in tests, so I can't add it in In the meantime I found that empty enum variants can still trigger this lint, so I had to add another Here is some code that can trigger both cases: //! Testing `clippy::missing_docs_in_private_items`.
#![warn(clippy::missing_docs_in_private_items)]
use pin_project::pin_project;
#[pin_project(project_replace)]
pub struct Test1 {
pub test: u8, // Triggered here.
}
#[pin_project(project = Test2Proj)]
pub enum Test2 {
VariantA(u8),
VariantB, // Triggered here.
} |
I guess one last idea to get this lint tested would be to make a sub-crate only for lint testing, so it's not behind a |
I think this (convert the |
Done. |
3624259
to
a363a97
Compare
a363a97
to
5bc8a1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Published in 1.1.4. |
Apparently
clippy::missing_docs_in_private_items
triggers in proc-macros, seeing thatpin-project
already adds a sizable amount of#[allow(...)]
s I thought a PR might not hurt.I also submitted an issue at Clippy: rust-lang/rust-clippy#12197.