Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magic-folder-api should load config read-only #591

Open
meejah opened this issue Nov 22, 2021 · 2 comments
Open

magic-folder-api should load config read-only #591

meejah opened this issue Nov 22, 2021 · 2 comments

Comments

@meejah
Copy link
Collaborator

meejah commented Nov 22, 2021

There are some occasional spurious integration test failure on Windows and MacOS to do with "database being locked".

My current theory is that this is due to running magic-folder-api subcommands when the "main" process is doing database-stuff (although I'm unsure why they don't just fail 100% of the time, unless sqlite3 only actually locks the database when there's a write transaction?)

In any case, it would be better practice to have magic-folder-api only open in read-only mode since it doesn't need write-access and -- ideally -- that would also fix these occasional problems.

(It would also be possible to fix by just doing HTTP transaction instead of running magic-folder-api commands, but the latter is what most downstream CLI users would usually do so it's a better "integration test" IMO if the integration tests do that too...)

@meejah
Copy link
Collaborator Author

meejah commented Nov 22, 2021

See also #339

@meejah
Copy link
Collaborator Author

meejah commented Nov 29, 2021

Investigation required: how does locking work with sqlite, and is it platform-dependent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant