Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

Fix API inconsistency Assets\Email::create() #37

Open
iamEAP opened this issue May 8, 2015 · 1 comment
Open

Fix API inconsistency Assets\Email::create() #37

iamEAP opened this issue May 8, 2015 · 1 comment
Labels
est-1 priority-very_low skill-back_end status-triaged task-bug value-1
Milestone
1.0

Comments

@iamEAP
Copy link
Contributor

iamEAP commented May 8, 2015

The extra validation on Email::create() is nice, but the method's signature does not match that of CreateableInterface::create().

We should fix this, but we'll have to wait for 1.0.x, since this has been out in the wild for awhile.
@iamEAP iamEAP added the bug label May 8, 2015
@iamEAP iamEAP added this to the 1.0 milestone May 8, 2015
@jtwalters jtwalters changed the title Fix API inconsistency Assets\Email::create() Fix API inconsistency Assets\Email::create() [1] Jun 19, 2015
@jtwalters jtwalters changed the title Fix API inconsistency Assets\Email::create() [1] Fix API inconsistency Assets\Email::create() Jun 19, 2015
@doublejosh
Copy link

@iamEAP please mark or invalidate.

@doublejosh doublejosh reopened this Apr 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
est-1 priority-very_low skill-back_end status-triaged task-bug value-1
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@doublejosh @iamEAP