Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from CodeClimate #73

Open
simenandre opened this issue Oct 11, 2020 · 0 comments
Open

Fix issues from CodeClimate #73

simenandre opened this issue Oct 11, 2020 · 0 comments
Labels
needs-triage Needs attention from the triage team

Comments

@simenandre
Copy link
Member

We currently have 31 issues on Codeclimate. I think we should fix them, but after Project Barebone is done, of course.

Most of these issues are duplication (22); typical example:

Similar blocks of code found in 2 locations. Consider refactoring.

<Box sx={{ mb: 5 }}>
	<Flex sx={{ width: '100%', justifyContent: 'center' }}>
		<Heading as="h3" sx={{ flexGrow: 1 }}>
			Ordrestatus
		</Heading>
	...

The rest (9) are in complexity; typical example:

Function Orders has 55 lines of code (exceeds 25 allowed). Consider refactoring.

const Orders: React.FC = () => {
  const navigate = useNavigate();
  const data = Array(10).fill({
    orderNumber: '00001',
    orderDate: '26.05.2020',
	...

Reference:
https://codeclimate.com/github/tabetalt/backoffice/issues

@simenandre simenandre added the needs-triage Needs attention from the triage team label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs attention from the triage team
Projects
None yet
Development

No branches or pull requests

1 participant