New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Storage Factory mockable #20

Open

emulgeator opened this issue May 24, 2015 · 2 comments

Milestone

Collaborator

emulgeator commented May 24, 2015

Storage Factory is a simple static class which makes it impossible to mock.

emulgeator modified the milestone: v0.4.0

Owner

szeber commented Jun 10, 2015

I agree, probably best to move it in the DI container, and make the methods non static.

Collaborator Author

emulgeator commented Jun 24, 2015

Before even doing it, please give an example about the DI solution you mentioned before (when we spoke)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment